adding feature to assign custom output filename#37
Open
siddarth-patil wants to merge 1 commit intobguise987:masterfrom
Open
adding feature to assign custom output filename#37siddarth-patil wants to merge 1 commit intobguise987:masterfrom
siddarth-patil wants to merge 1 commit intobguise987:masterfrom
Conversation
RPINerd
approved these changes
Feb 20, 2023
RPINerd
left a comment
RPINerd
left a comment
There was a problem hiding this comment.
Definitely a good addition feature, almost a must depending on application!
Owner
|
Hey @siddarth-patil sorry I didn't get to this sooner, the notification slipped through the cracks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue of not being able to specify the output file name when using the package. The changes add a new parameter to the function that allows the user to specify the desired output file name. The default behavior remains unchanged if the user does not specify a custom file name.
Changes Made
output_nameparameter to the functionoutput_nameparameter is provided, the output will be saved to a file with that name. If the parameter is not provided, the default file name will be used.output_nameprovided by user.Closes #36